-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to hide icon and its value if 0 #163
Open
Yoannjap
wants to merge
292
commits into
isDipesh:master
Choose a base branch
from
UshakovVasilii:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle sensors of radeon & nouveau drivers as GPUs
Since the card list is populated only in constructor, to update it we had to toggle "Nvidia" switch `on`->`off`->`on`. The fix is to get the temperature along with the card name in one `nvidia-smi` call. Also some code cleanup was made, removed old unused code. Fixes #241 Signed-off-by: Pavel Artsishevsky <[email protected]>
Co-authored-by: Divine Bicycle <[email protected]>
* Only poll NVIDIA GPUs which are awake. * Slow down polling if an NVIDIA GPU can sleep. If an NVIDIA GPU is eligible to sleep, i.e. runtime D3 sleep is enabled and no processes except GNOME or X.org are running, then don't poll the GPU for at least another 30 seconds. * NVIDIA: Check for X.org correctly on most distros. If a distro is naming X.org differently than these common and sensible names, then we can't detect or account for that in any way unfortunately * Show N/A instead when NVIDIA GPU is sleeping.
* Fix two typos in three strings - syetem - NVidia * Typo: Fix double "from" usage in prefs.js * Mark two strings translatable - Temperature Unit - Direct * Update freon.pot file * Update Turkish translation
This allows "Core 3" to sort before "Core 20", instead of the other way around without the numeric option set.
* Migrate Plugin to Gnome 45 Shell * Use TextDecoder instead of ByteArray or toString() * use the Glib timeout functions * remove unused imports
* replace global.log() with logError() * remove run_dispose calls This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose * use pkexec instead of sudo for ipmi-sensors
Those Functions were deprecated and got removed in GNOME 46
… drive without a temperature.
getSmartData(...) temperature is undefined #209
Change prefs to libadwaita, add battery sensors
Mark compatible with GNOME Shell 47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for your brilliant extension, very useful and handy.
May you add an option to check as it would be possible to hide fan rpm if it is 0 rpm?